Gammatone optimization using Eigen matrix operations #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, I am opening this PR to propose some gammatone filterbank optimizations using matrix operations with the Eigen library.
The proposed changes have two parts:
The proposed changes show bigger runtime improvements for shorter input files, and from our measurements we can see approx. 1.5x faster runtime for a 15" input, up to 2x for a 3" input file.
If we also combine this improvement with
--search_window_radius 0and--disable_realignment(when reference and degraded have no inter-frame lag), we could get approx. 5x faster runtimes for a 15" input.The changes in this PR are a bit lengthy so I am also opening PR #116 with only the first part that replaces Armadillo with Eigen to keep it more contained and make the review process a bit easier. I also opened terpste#6 only for comparison purposes, to highlight only the gammatone filterbank additions.